Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: tests: convert core to mocha #14035

Closed
wants to merge 32 commits into from
Closed

WIP: tests: convert core to mocha #14035

wants to merge 32 commits into from

Conversation

connorjclark
Copy link
Collaborator

@connorjclark connorjclark commented May 21, 2022

See #14047

To run:

yarn mocha lighthouse-core/test

ref #13568
#14020 was merged into this branch too.

@connorjclark connorjclark requested a review from a team as a code owner May 21, 2022 00:13
@connorjclark connorjclark requested review from adamraine and removed request for a team May 21, 2022 00:13
@connorjclark connorjclark marked this pull request as draft May 21, 2022 00:13
@connorjclark connorjclark changed the base branch from master to mocha May 21, 2022 00:14
@connorjclark
Copy link
Collaborator Author

connorjclark commented May 23, 2022

I've been only testing with Node 14 locally, but turns out Node 16/17 error due to some bug re: marky (which uses performance.mark) and @jest/fake-timers (which mocks process.hrtime).

It's only navigation-test.js, which I suppose explains this import at the top:

import 'lighthouse-logger'; // Needed otherwise `log.timeEnd` errors in navigation.js inexplicably.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants