new_audit: add work-during-interaction diagnostic #13982
Conversation
| const displayValue = str_(UIStrings.displayValue, {timeInMs: duration, interactionType}); | ||
|
|
||
| return { | ||
| score: duration < MAX_DURATION_THRESHOLD ? 1 : 0, |
There was a problem hiding this comment.
This pass/fail condition is directly tied to the actual INP value. It seems like this audit is similar to layout-shift-elements because it provides a detailed breakdown of the metric value. WDYT about making this an informative audit just like layout-shift-elements?
There was a problem hiding this comment.
I forget the argument now for layout-shift-elements, but it would seem strange to me not to put a pass/fail on this audit. If it's a slow interaction we should highlight it in red as an important diagnostic to focus on. Happy to discuss this more, though.
However it doesn't make sense to use an arbitrary threshold, I had it in there for testing and forgot about it. I updated to pull the p10 from the INP audit.
There was a problem hiding this comment.
This is fine, but would like to discuss after 9.6
| let totalExecutionTimeForURL = 0; | ||
| for (const [groupId, timespanMs] of Object.entries(timingByGroupId)) { | ||
| if (timespanMs === 0) continue; | ||
| timingByGroupId[groupId] = timespanMs; |
There was a problem hiding this comment.
What is this line doing? Seems like it will never change timingByGroupId
There was a problem hiding this comment.
What is this line doing? Seems like it will never change
timingByGroupId
Good catch, it's doing nothing :)
Originally it was a CPU multiplier line (brought over from BootupTime), but since this doesn't support simulated throttling, it became useless.
| const displayValue = str_(UIStrings.displayValue, {timeInMs: duration, interactionType}); | ||
|
|
||
| return { | ||
| score: duration < MAX_DURATION_THRESHOLD ? 1 : 0, |
There was a problem hiding this comment.
This is fine, but would like to discuss after 9.6
part of #13916
Breaks down the tasks occurring during the INP event. Tests are very light, still working on them
Example report: https://lighthouse-ddszazj4j-googlechrome.vercel.app/gh-pages/viewer/?gist=0b9f538660fe83c57c94acb5b6a04be0