cli: use fraggle rock runner by default, deprecate legacy navigation runner #13860
Conversation
connorjclark
changed the title
connorjclark
changed the title
lighthouse-cli/cli-flags.js
Outdated
| type: 'boolean', | ||
| default: false, | ||
| describe: '[EXPERIMENTAL] Use the new Fraggle Rock navigation runner to gather results.', | ||
| describe: '[DEPRECATED] Use the legacy navigation runner to gather results.', |
There was a problem hiding this comment.
Say more about why you might want to use this? I don't think we have any specific scenarios where FR runner would break so maybe just say "only use if default runner doesn't work, and please file a bug"?
There was a problem hiding this comment.
I don't think we have any specific scenarios where FR runner would break
The new config format would break some clients. I'll add a note about that.
This might be a good time to update the config docs, so we know what our story will be.
|
Can you investigate the CI failures? |
| @@ -3,6 +3,6 @@ | |||
| # Make sure we're in this `docs/recipes/customer-gatherer-puppeteer` directory | |||
| cd "$(dirname "$0")" | |||
|
|
|||
| node node_modules/.bin/lighthouse --config-path=custom-config.js https://www.example.com --output=json | | |||
| node node_modules/.bin/lighthouse --legacy-navigation --config-path=custom-config.js https://www.example.com --output=json | | |||
There was a problem hiding this comment.
This recipe won't work in FR because it uses driver.wsEndpoint() which doesn't exist on the FR driver. We could add the function, or instead we could add a driver.getPage so users can easily get the correct puppeteer page to use.
That will be done in a separate PR as part of our docs updates.
Doc