Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: make requestedUrl optional #13816

Merged
merged 8 commits into from
Apr 5, 2022
Merged

core: make requestedUrl optional #13816

merged 8 commits into from
Apr 5, 2022

Conversation

adamraine
Copy link
Member

Part 4 of #13706

@adamraine adamraine requested a review from a team as a code owner April 4, 2022 21:27
@adamraine adamraine requested review from connorjclark and removed request for a team April 4, 2022 21:27
connorjclark
connorjclark approved these changes Apr 4, 2022
View reviewed changes
lighthouse-core/fraggle-rock/gather/base-artifacts.js Outdated Show resolved Hide resolved
types/lhr/lhr.d.ts Outdated Show resolved Hide resolved
@adamraine adamraine merged commit 1e598da into master Apr 5, 2022
@adamraine adamraine deleted the optional-requestedurl branch April 5, 2022 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@connorjclark connorjclark connorjclark approved these changes

Assignees

@connorjclark connorjclark

Labels
breaking waiting4reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adamraine @connorjclark @devtools-bot