core: mindfully order properties in the lhr #13418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
reviewed
Nov 23, 2021
| requestedUrl: requestedUrl, | ||
| finalUrl: artifacts.URL.finalUrl, | ||
| runWarnings: lighthouseRunWarnings, | ||
| runtimeError: Runner.getArtifactRuntimeError(artifacts), | ||
| audits: auditResultsById, |
There was a problem hiding this comment.
this one's also kinda big, can we move to right before timing?
There was a problem hiding this comment.
hmmm sure it's big, but it has all the most important info inside
adamraine
approved these changes
Nov 23, 2021
connorjclark
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Look at a flow result, I found myself scanning a bit to find out what url a result was for. That made me consider the ordering of the properties in an LHR.
I think it'd be beneficial to human readability of this json to tweak the ordering a bit.
I think this orders the properties in the most informational manner:
* arguable could go somewhere else
Secondly, I moved
i18nto be the last item. It being a giant object of strings it kinda makes one gloss over anything that follows. It's also the most meta, making references throughout the rest of the LHR, so delegating it to last place makes some sort of sense to me