report(treemap): correct percentages when 0 bytes JS #13382
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when there were 0 total bytes JS on a page, treemap will take percentages of that 0 and happily show you
https://example.com/ · Resource Bytes: 0 B (NaN%)
We saw it on example.com, but also noticed by at least one user.
The "correct" percentage is arguable but since there's just the one entry on the page 100% seemed more reasonable than 0%, since that just leaves you wondering where the rest of the 0 bytes are :)
Testing is awkward. I could change
debug.json
to include a subnode with 0 total but it seems fiddly (would the test have to click into the subtree to trigger this path?). Add a new pptr test just for this?fixes #13383