report(flow): report api #13374
Merged
report(flow): report api #13374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
commented
Nov 15, 2021
| function __initLighthouseFlowReport__() { | ||
| // TODO(adamraine): add lh-vars, etc classes programmatically instead of in the HTML template |
There was a problem hiding this comment.
Drive-by resolving this TODO
| * @return {DocumentFragment} | ||
| */ | ||
| function renderCategoryScore(category, options) { | ||
| const dom = new DOM(document, document.documentElement); |
There was a problem hiding this comment.
@paulirish we discussed making these globals, but that lead to some jest issues where the globals are persistent across tests. I didn't think it would be a big deal to create new instances on each call.
Another option would be to use globals and expose a _resetGlobals function for testing or something.
There was a problem hiding this comment.
yeah i like what you did here. this seems like a great solution for now.
paulirish
approved these changes
Nov 18, 2021
| * @return {DocumentFragment} | ||
| */ | ||
| function renderCategoryScore(category, options) { | ||
| const dom = new DOM(document, document.documentElement); |
There was a problem hiding this comment.
yeah i like what you did here. this seems like a great solution for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use new report api in the flow report and removes
ReportRendererContext. We still do some flow-specific stuff (e.g. removing labels from gauges), but it's handled by options on the report API now.Individual LH reports in the flow will now be initialized with
ReportUIFeatures, adding support for the treemap button and 3P filter in flows. Topbar, dark mode, and fireworks are disabled via report api options.