misc(build): prevent over optimization of computeBenchmarkIndex #13366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice find! Really it's not great for a sufficiently advanced JS engine either. v8 just needs a small tweak to its heuristics and it would notice the same opportunity. The traditional way around this is to assert anything about the end result. e.g. Would that work instead of special casing the file? |
connorjclark
changed the title
adamraine
approved these changes
Nov 12, 2021
connorjclark
changed the title
connorjclark
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollup was deleting the
for (let j = 0; j < 10000; j++) s += 'a';line in the benchmark index function, resulting in a value of 500,000+ in bundled results.