core(installable-manifest): pipeline-restarted check #13365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a desktop PWA is uninstalled but has other open windows in scope, the pipeline-restarted message will be logged, signalling that the app install banner state has been reset. pipeline-restarted will be ignored by Lighthouse, as there is currently no reason audit the behavior of desktop PWAs after the app has been uninstalled. The related test has also been updated to run again.
…nto issue-13147-pipline-restarted
Minor spelling mistake.
Fixing formatting errors
Re-adding protocol-timeout to my branch.
…nto issue-13147-pipline-restarted
adamread
changed the title
adamread
changed the title
adamread
changed the title
adamread
changed the title
adamread
changed the title
connorjclark
approved these changes
Nov 17, 2021
connorjclark
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds the pipeline-restarted installable logging message to the installable-manifest audit.
This change brings the installable-manifest audit in line with the messages included in Chromium, allowing the automated comparison to run without complaining that something is missing.
The related test is also no longer skipped.
The pipeline-restarted message was introduced in Chromium commit 03777af. The message indicates that the app has been uninstalled, possibly in a context outside the currently active tab, and that the installability checks are being reset. This is only used on desktop. As Lighthouse won't be uninstalling the app, we filter the message out.
Related Issues/PRs
This is the first half of Issue 13147