Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report(help-dialog): remove timespan SEO #13354

Merged
merged 3 commits into from
Nov 10, 2021
Merged

Conversation

adamraine
Copy link
Member

SEO was removed from timespans, help dialog needed updating.

@adamraine adamraine requested a review from a team as a code owner November 10, 2021 18:48
@adamraine adamraine requested review from adamread and removed request for a team November 10, 2021 18:48
@google-cla google-cla bot added the cla: yes label Nov 10, 2021
Copy link
Contributor

@adamread adamread left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I don't think I need the context for you removing one line and the failing smoke tests seem unrelated to this change.

@paulirish
Copy link
Member

LGTM. I don't think I need the context for you removing one line and the failing smoke tests seem unrelated to this change.

yah all good. :)

@adamread we have an automatic reviewer rotation. i added you to lighthouse-hackers team so you have push access to the repo. but in doing so it put you in the rotation. :p i just removed you so you don't have to deal with these. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants