report(flow): remove smooth scrolling #13317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
what about just not using w/o behavior:smooth you'd be consistent with the existing scrollIntoView: lighthouse/report/renderer/report-renderer.js Line 225 in 993fbc9 |
We were trying to avoid the category looking like it's on its own page. That was speculation though, so we can remove the smooth scroll and see if confusion arrises at all. |
adamraine
changed the title
paulirish
approved these changes
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was noticing that Chrome would (usually) scroll too far when clicking a category link on the summary page. This only happens when using
{behavior: 'smooth'}.Executing
scrollIntoViewinuseEffectseems to have fixed the problem since the body is run after paint. We still want the scroll-to-top feature to execute before the first paint, so that is given it's ownuseLayoutEffect.