-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
report: hidden group backcompat #13310
Conversation
This is a lie. Sufficient changes to the config could break the expectation. I think the safest approach is to switch to a version check, and merge alongside the v9 bump. |
are you making a change here? |
Since the solution is to look for an LHR with version >=9.0.0 I don't think we can merge this until the version bump. I was planning on making this a part of the version bump PR if possible. |
gotcha! yeah totally makes sense. i think you could use |
package.json
Outdated
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "lighthouse", | |||
"version": "8.6.0", | |||
"version": "8.7.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pretty weird, wish I had an alternative idea. At least, how about 9.0.0-alpha.0
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is fine. i considered it but got scared. but sure.
If the user happens to be using a config with no audits in group
"hidden"
, but they're on v9, this shouldn't affect anything.