report(build): fix building flow report with inline-fs

[brendankenny]

the change in #13275 to unguard the fs.readdirSync broke the flow report because it didn't have a call to inlineFs in the build call. This adds the plugin and fixes it.

This does add 466 bytes (the list of supported locales) to the flow report that aren't used. I assume there will be better DCE when switching to es modules and rollup will be more aggressive with tree shaking?

[adamraine]

The files being read are not used by the flow report, so wouldn't this unnecessarily increase the size of the bundle?

[brendankenny]

that's the 466 bytes I mentioned. It's not the files themselves, it's the locales file list. The format.js line ends up as

It=["ar-XB.json","ar.json","bg.json","ca.json","cs.json","da.json","de.json","el.json","en-GB.json","en-US.ctc.json","en-US.json","en-XA.json","en-XL.ctc.json","en-XL.json","es-419.json","es.json","fi.json","fil.json","fr.json","he.json","hi.json","hr.json","hu.json","id.json","it.json","ja.json","ko.json","lt.json","lv.json","nl.json","no.json","pl.json","pt-PT.json","pt.json","ro.json","ru.json","sk.json","sl.json","sr-Latn.json","sr.json","sv.json","ta.json","te.json","th.json","tr.json","uk.json","vi.json","zh-HK.json","zh-TW.json","zh.json"].filter((e=>e.endsWith(".json")&&!e.endsWith(".ctc.json"))).map((e=>e.replace(".json",""))).sort()

another option would be changing the rollup shim to something like 'fs': 'export function readdirSync() {return []}',. The downside would be it's more fragile to future additions of fs methods 🤷

[adamraine]

Ah ok, this is fine then 👍