report(psi): retire prepareLabData, reuse standard report rendering #13229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
approved these changes
Oct 19, 2021
There was a problem hiding this comment.
lovely PR
(not sure when @connorjclark will be back but feel free to disregard the LGTM if you'd rather wait for his check)
| /** | ||
| * @param {Document} doc | ||
| */ | ||
| function getRenderer(doc) { |
There was a problem hiding this comment.
any reason for this to be a function? just going for a regular
const dom = new lighthouseRenderer.DOM(reportContainer.ownerDocument);
const renderer = new lighthouseRenderer.ReportRenderer(dom);seems more straightforward
There was a problem hiding this comment.
i am mirroring some internal impl structure used elsewhere. ;)
thats why this indirection is added. :)
report/test/clients/bundle-test.js
Outdated
| // Check that the report exists and has some content. | ||
| expect(reportContainer instanceof document.defaultView.Element).toBeTruthy(); | ||
| expect(reportContainer.outerHTML.length).toBeGreaterThan(50000); | ||
| // fs.writeFileSync('./supp.html', reportContainer.outerHTML, 'utf-8'); |
Co-authored-by: Brendan Kenny <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with v8.6.0 shipped we can now land our breaking report changes.
(legacy) PSI frontend may get updated to 8.6.0 but nothing further.
This PR removes the hacks-upon-hacks that is
prepareLabData(). Yay for deleting some serious debt. 🎉Now, the faux-psi sample report will adopt the standard report rendering approach currently used by psi-next. But otherwise it has tabs.
With this done, there are a few 'broken' items in faux-psi that I'll be addressing in followups.