Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(image-size-responsive): remove elidedUrl, elide url property instead #13226

Merged
merged 21 commits into from
Oct 29, 2021
Merged

core(image-size-responsive): remove elidedUrl, elide url property instead #13226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
a288f9e
fix: drop image size responsiveness
prerana1821 Oct 17, 2021
76a43f4
fix: formatting
prerana1821 Oct 18, 2021
556a662
fix: lighthouse version
prerana1821 Oct 18, 2021
7fd1522
fix: removed not required changes
prerana1821 Oct 19, 2021
5ad1b48
fix: undo formatting changes
prerana1821 Oct 21, 2021
2fb2c6d
fix: undo formatting changes
prerana1821 Oct 21, 2021
9a15074
fix: undo formatting changes
prerana1821 Oct 21, 2021
84bc9cf
fix: formatting changes
prerana1821 Oct 21, 2021
7901e6b
fix: space formatting changes
prerana1821 Oct 22, 2021
9049403
fix: space formatting changes
prerana1821 Oct 22, 2021
3b24f1d
fix: space formatting changes
prerana1821 Oct 22, 2021
15441b8
fix: space formatting changes
prerana1821 Oct 22, 2021
9ee2fd0
fix: space formatting changes
prerana1821 Oct 22, 2021
4585874
fix: formatting changes
prerana1821 Oct 22, 2021
7f8a238
fix: formatting changes
prerana1821 Oct 22, 2021
832df61
fix: merge conflicts
prerana1821 Oct 28, 2021
15d397d
fix: formatting changes
prerana1821 Oct 28, 2021
9faa284
fix: formatting changes
prerana1821 Oct 28, 2021
e8e3c7f
update sample
adamraine Oct 28, 2021
e427b17
nit
adamraine Oct 28, 2021
80ba2ba
sample
adamraine Oct 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions lighthouse-core/audits/image-size-responsive.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ const LARGE_IMAGE_FACTOR = 0.75;
// considered SMALL.
const SMALL_IMAGE_THRESHOLD = 64;

/** @typedef {{url: string, node: LH.Audit.Details.NodeValue, elidedUrl: string, displayedSize: string, actualSize: string, actualPixels: number, expectedSize: string, expectedPixels: number}} Result */
/** @typedef {{url: string, node: LH.Audit.Details.NodeValue, displayedSize: string, actualSize: string, actualPixels: number, expectedSize: string, expectedPixels: number}} Result */

/**
* @param {{top: number, bottom: number, left: number, right: number}} imageRect
Expand Down Expand Up @@ -146,9 +146,8 @@ function getResult(image, DPR) {
const [expectedWidth, expectedHeight] =
expectedImageSize(image.displayedWidth, image.displayedHeight, DPR);
return {
url: image.src,
url: URL.elideDataURI(image.src),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing elidedUrl here is good.

node: Audit.makeNodeItem(image.node),
elidedUrl: URL.elideDataURI(image.src),
displayedSize: `${image.displayedWidth} x ${image.displayedHeight}`,
actualSize: `${image.naturalDimensions.width} x ${image.naturalDimensions.height}`,
actualPixels: image.naturalDimensions.width * image.naturalDimensions.height,
Expand Down Expand Up @@ -265,7 +264,7 @@ class ImageSizeResponsive extends Audit {
/** @type {LH.Audit.Details.Table['headings']} */
const headings = [
{key: 'node', itemType: 'node', text: ''},
{key: 'elidedUrl', itemType: 'url', text: str_(i18n.UIStrings.columnURL)},
{key: 'url', itemType: 'url', text: str_(i18n.UIStrings.columnURL)},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removal of the elidedUrl heading is good. We like to keep each heading entry on a single line though. Anything else I didn't highlihgt is a style change we don't need.

{key: 'displayedSize', itemType: 'text', text: str_(UIStrings.columnDisplayed)},
{key: 'actualSize', itemType: 'text', text: str_(UIStrings.columnActual)},
{key: 'expectedSize', itemType: 'text', text: str_(UIStrings.columnExpected)},
Expand Down
3 changes: 1 addition & 2 deletions lighthouse-core/test/results/sample_v2.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -951,7 +951,7 @@
"text": ""
},
{
"key": "elidedUrl",
"key": "url",
"itemType": "url",
"text": "URL"
},
Expand Down Expand Up @@ -990,7 +990,6 @@
"snippet": "<img src=\"lighthouse-480x318.jpg?isr1\" width=\"360\" height=\"240\" style=\"position: absolute;\">",
"nodeLabel": "body > img"
},
"elidedUrl": "http://localhost:10200/dobetterweb/lighthouse-480x318.jpg?isr1",
"displayedSize": "360 x 240",
"actualSize": "480 x 318",
"actualPixels": 152640,
Expand Down