report(build): create UMD bundle build #12898
Conversation
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
stand down bot it was just me @googlebot I consent. |
|
|
||
| # copy report code $fe_lh_dir | ||
| fe_lh_report_dir="$fe_lh_dir/report/" | ||
| cp dist/report/bundle.js dist/report/bundle.d.ts "$fe_lh_report_dir" | ||
| cp dist/report/bundle.esm.js "$fe_lh_report_dir/bundle.js" | ||
| cp dist/report/bundle.esm.d.ts "$fe_lh_report_dir/bundle.d.ts" |
There was a problem hiding this comment.
I assume you saw that the type files generated for both module types ended up being the same (makes sense)?
There was a problem hiding this comment.
yup. but thx for calling out.
We need a UMD bundle build of the report for PSI. The ESM bundle doesn't fly there.
Also note that this build-report file is being adjusted in https://github.com/GoogleChrome/lighthouse/pull/12815/files. I'm assuming this PR here will land first before 12815, and i'll rebase that one.