Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc(build): remove template.html from devtools report resources #12891

Merged
merged 4 commits into from
Aug 13, 2021
Merged

misc(build): remove template.html from devtools report resources #12891

merged 4 commits into from
Aug 13, 2021

Conversation

connorjclark
Copy link
Collaborator

Could have removed this in #12803 but did not realize.

@connorjclark connorjclark requested a review from a team as a code owner August 10, 2021 18:11
@connorjclark connorjclark requested review from adamraine and removed request for a team August 10, 2021 18:11
@google-cla google-cla bot added the cla: yes label Aug 10, 2021
@connorjclark
Copy link
Collaborator Author

ninja: error: '../../front_end/third_party/lighthouse/report-assets/templates.html', needed by 'gen/front_end/entrypoints/devtools_app/devtools_app.js', missing and no known rule to make it

Ah, nevermind. Will need to remove references to templates.html from CDT build rules first.

@adamraine
Copy link
Member

https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3088413/1..2

@devtools-bot devtools-bot merged commit 5bc90d7 into master Aug 13, 2021
@devtools-bot devtools-bot deleted the dt-templates branch August 13, 2021 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamraine adamraine adamraine approved these changes

Assignees

@adamraine adamraine

Labels
cla: yes waiting4reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@connorjclark @adamraine @devtools-bot