-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new_audit(axe): input-button-name, role-img-alt, select-name #12700
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, but missing changes to a11y smoke tests
* @url https://github.com/dequelabs/axe-core/pull/1586 | ||
*/ | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description: 'When an input button doesn\'t have an accessible name, screen readers announce ' + | ||
'it as "button", making it unusable for users who rely on screen readers. ' + | ||
'[Learn more](https://dequeuniversity.com/rules/axe/4.1/input-button-name?application=lighthouse).', | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
protip: we automatically ignore max-len for lines with URLs. so you dont have to do the string concat bs (which is liable to generating spacing issues)
|
||
const UIStrings = { | ||
/** Title of an accesibility audit that evaluates if all select elements have corresponding label elements. This title is descriptive of the successful state and is shown to users when no user action is required. */ | ||
title: 'Select elements have associated labels', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
title: 'Select elements have associated labels', | |
title: '`<select>` elements have associated labels', |
so translators dont touch it
builds off #12699
Adds the 3 audits that the new test detected as missing. All 3 of them were split out of other rules we already used.. We just missed it when they were split out.
I went over all descriptions/ids carefully and i feel fairly confident its looking good.
Driveby: I added a test to confirm all audits in default config are in use by a category
update: i realize now that this PR has some overlap with #12536