Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(csp-xss): add severity text column to report #12551

Merged
merged 9 commits into from
May 25, 2021
Merged

Conversation

adamraine
Copy link
Member

@adamraine adamraine commented May 24, 2021

While working on the web.dev documentation, I thought it would be useful to map the section headers to severity indicators in the report. Our last discussion on this ruled out using icons, but I would like to gauge interest in a simple text value. Documentation elaborates on the meaning of "High" and "Medium".

Screen Shot 2021-05-24 at 3 40 11 PM

@adamraine adamraine requested a review from a team as a code owner May 24, 2021 18:04
@adamraine adamraine requested review from patrickhulce and removed request for a team May 24, 2021 18:04
@google-cla google-cla bot added the cla: yes label May 24, 2021
Copy link
Collaborator

@connorjclark connorjclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good to me, but we can discuss in eng meeting

lighthouse-core/lib/i18n/i18n.js Outdated Show resolved Hide resolved
Copy link
Member

@paulirish paulirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one thing i'll raise before we merge it…

lighthouse-core/audits/csp-xss.js Show resolved Hide resolved
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Communicating the severity within the audit SGTM, IIRC most of my thoughts here were around communication of the severity of the audit as a whole, which this doesn't touch yet 👍

lighthouse-core/audits/csp-xss.js Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants