-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core(csp-xss): add severity text column to report #12551
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems good to me, but we can discuss in eng meeting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one thing i'll raise before we merge it…
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Communicating the severity within the audit SGTM, IIRC most of my thoughts here were around communication of the severity of the audit as a whole, which this doesn't touch yet 👍
While working on the web.dev documentation, I thought it would be useful to map the section headers to severity indicators in the report. Our last discussion on this ruled out using icons, but I would like to gauge interest in a simple text value. Documentation elaborates on the meaning of "High" and "Medium".