report(viewer): fix gist icon #12505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -381,20 +381,20 @@ | |||
| <a href="" class="lh-topbar__url" target="_blank" rel="noopener"></a> | |||
|
|
|||
| <div class="lh-tools"> | |||
| <button id="lh-tools-button" class="lh-tools__button" title="Tools menu" aria-label="Toggle report tools menu" aria-haspopup="menu" aria-expanded="false" aria-controls="lh-tools-dropdown"> | |||
| <button id="lh-tools-button" class="lh-tools__button" title="Tools menu" aria-label="Toggle report tools menu" aria-haspopup="menu" aria-expanded="false" aria-controls="lh-tools__dropdown"> | |||
There was a problem hiding this comment.
this doesn't seem right, lh-tools__dropdown is just a class, we want the ID to stay, no? Is this related to the icon?
There was a problem hiding this comment.
oops, global find/replace .... will add back
patrickhulce
approved these changes
May 18, 2021
| display: block !important; | ||
| /* save-gist option visible in Viewer */ | ||
| .lh-tools__dropdown a[data-action="save-gist"] { | ||
| display: flex !important; |
There was a problem hiding this comment.
heh, does this affect anything or just for funsies? :)
There was a problem hiding this comment.
yeah the icon stuff requires flex, not block. i dont recall why
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forgot to update this tool icon in #12392