Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report: remove title from audit clump expand #11989

Merged
merged 5 commits into from
Jan 26, 2021
Merged

report: remove title from audit clump expand #11989

merged 5 commits into from
Jan 26, 2021

Conversation

connorjclark
Copy link
Collaborator

@connorjclark connorjclark requested a review from a team as a code owner January 22, 2021 19:46
@connorjclark connorjclark requested review from patrickhulce and removed request for a team January 22, 2021 19:46
@google-cla google-cla bot added the cla: yes label Jan 22, 2021
@brendankenny
Copy link
Member

should probably also remove it from

lighthouse/lighthouse-core/report/html/templates.html

Line 137 in 066ac9f

<div class="lh-chevron-container" title="See resources"></div>

(the other .lh-chevron-container doesn't have one so is good)

brendankenny
brendankenny approved these changes Jan 22, 2021
View reviewed changes
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@devtools-bot devtools-bot merged commit f97cabf into master Jan 26, 2021
@devtools-bot devtools-bot deleted the rm-title-audit-expand branch January 26, 2021 18:06
paulirish pushed a commit that referenced this pull request Mar 23, 2021
@connorjclark @paulirish
report: remove title from audit clump expand (#11989)
6ab9a19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhulce patrickhulce patrickhulce approved these changes

@brendankenny brendankenny brendankenny approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@connorjclark @brendankenny @patrickhulce @devtools-bot