Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(fr): add navigations to config #11957

Merged
merged 2 commits into from
Jan 19, 2021
Merged

Conversation

patrickhulce
Copy link
Collaborator

Summary
Adds basic navigations to the fraggle rock config. I decided to go ahead and document the complete navigation config object so everyone can see where it's headed and what replaces what even if the properties aren't supported in the navigation prototype yet (see config.d.ts).

Fraggle Rock Config

const configJson = {
    artifacts: [{id: 'Accessibility', gatherer: 'accessibility'}],
    navigations: [{id: 'default', artifacts: ['Accessibility']}],
};

Legacy Config

const configJson = {
    passes: [{passName: 'defaultPass', gatherers: ['accessibility']}],
};

Related Issues/PRs
ref #11313
design doc

@patrickhulce patrickhulce requested a review from a team as a code owner January 14, 2021 18:02
@patrickhulce patrickhulce requested review from connorjclark and removed request for a team January 14, 2021 18:02
@google-cla google-cla bot added the cla: yes label Jan 14, 2021
@patrickhulce patrickhulce merged commit ef387d8 into master Jan 19, 2021
@patrickhulce patrickhulce deleted the fr_config_navigations branch January 19, 2021 14:42
paulirish pushed a commit that referenced this pull request Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants