Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report: treemap opener, ?dev for localhost viewer and treemap #11667

Merged
merged 11 commits into from
Nov 17, 2020
Merged

report: treemap opener, ?dev for localhost viewer and treemap #11667

merged 11 commits into from
Nov 17, 2020

Conversation

connorjclark
Copy link
Collaborator

ref #11254, split off from #11545

@connorjclark connorjclark requested a review from a team as a code owner November 13, 2020 21:58
@connorjclark connorjclark requested review from adamraine and removed request for a team November 13, 2020 21:58
@google-cla google-cla bot added the cla: yes label Nov 13, 2020
patrickhulce
patrickhulce reviewed Nov 14, 2020
View reviewed changes
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool cool cool

lighthouse-core/report/html/renderer/report-ui-features.js Outdated Show resolved Hide resolved
lighthouse-core/report/html/renderer/report-ui-features.js Outdated Show resolved Hide resolved
lighthouse-core/report/html/renderer/report-ui-features.js Outdated Show resolved Hide resolved
adamraine
adamraine approved these changes Nov 16, 2020
View reviewed changes
Copy link
Member

@adamraine adamraine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM

lighthouse-core/report/html/renderer/report-ui-features.js Show resolved Hide resolved
patrickhulce
patrickhulce approved these changes Nov 17, 2020
View reviewed changes
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@connorjclark connorjclark changed the title report: add treemap opener, ?dev for localhost viewer and treemap report: treemap opener, ?dev for localhost viewer and treemap Nov 17, 2020
@connorjclark connorjclark merged commit cc54cb1 into master Nov 17, 2020
@connorjclark connorjclark deleted the treemap-reportui branch November 17, 2020 01:12
@brendankenny brendankenny mentioned this pull request May 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamraine adamraine adamraine approved these changes

@patrickhulce patrickhulce patrickhulce approved these changes

Assignees

@adamraine adamraine

Labels
cla: yes waiting4reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@connorjclark @patrickhulce @adamraine @devtools-bot