Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: add chromium webtests to npmignore #11512

Merged
merged 1 commit into from
Oct 2, 2020
Merged

misc: add chromium webtests to npmignore #11512

merged 1 commit into from
Oct 2, 2020

Conversation

patrickhulce
Copy link
Collaborator

@patrickhulce patrickhulce commented Oct 2, 2020

Summary
Our shiny new chromium webtests accidentally got included in our npm bundle :) I don't know if this is worthy of a 6.4.1 all by itself since installing all our dependencies takes 15 GB, but nice to get in for sure.

Before

$ pkgfiles
PKGFILES SUMMARY
Size on Disk with Dependencies  ~15 GB
Size with Dependencies          ~14.7 GB
Publishable Size                ~64.4 MB
Number of Directories           1056
Number of Files                 5773

After

$ pkgfiles
PKGFILES SUMMARY
Size on Disk with Dependencies  ~15 GB
Size with Dependencies          ~14.7 GB
Publishable Size                ~16.7 MB
Number of Directories           100
Number of Files                 633

Related Issues/PRs
fixes #11511

@patrickhulce patrickhulce requested a review from a team as a code owner October 2, 2020 15:12
@patrickhulce patrickhulce requested review from connorjclark and removed request for a team October 2, 2020 15:12
@connorjclark connorjclark merged commit ddd1496 into master Oct 2, 2020
@connorjclark connorjclark deleted the ignore_tmp branch October 2, 2020 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression in Lighthouse 6.4.0 – .tmp folder adds extra 50MB to the npm package
4 participants