misc(build): fix devtools tests by making empty type files #11418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
requested review from
paulirish
and removed request for
a team
10 tasks
connorjclark
changed the title
| @@ -33,6 +33,8 @@ writeFile('report.js', htmlReportAssets.REPORT_JAVASCRIPT); | |||
| writeFile('report.css', htmlReportAssets.REPORT_CSS); | |||
| writeFile('template.html', htmlReportAssets.REPORT_TEMPLATE); | |||
| writeFile('templates.html', htmlReportAssets.REPORT_TEMPLATES); | |||
| writeFile('report.d.ts', 'export {}'); | |||
| writeFile('report-generator.d.ts', 'export {}'); | |||
There was a problem hiding this comment.
Not important for this PR, but FWIW we can make these now. emitDeclarationOnly works for js now, and the report side of types are a lot more cleanly separated than the rest of LH. I don't know if it'll actually help with any DevTools integration, though.
paulirish
approved these changes
Sep 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #11414 (comment)
these files were added manually to our third party folder in CDT, but we destroy that folder when we roll, so we must make them.