Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new_audit: add script-treemap-data to experimental #11271
new_audit: add script-treemap-data to experimental #11271
Changes from 5 commits
118e461
c6bed57
bc6c57c
32a5c37
4b60ca3
a2cfff5
e6b3eb6
ac4e8a6
b12967e
f811334
a39a444
f28ef76
7008e55
1eec2e5
9c7e3a5
dca7c44
5d72ee9
8c05fc0
5976c3b
27137af
1446910
97e548f
556aa87
754ce53
5e97161
d878992
bb028dd
c2d78f1
106e608
0eac4f6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might be convinced to use transferBytes instead ..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resource seems fine for the treemap visualization (though eventually we might want both?), we don't exactly want to minimize the size of these over there :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would've expected the addNode function to handle this case. any reason it's separate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see a simple way to reduce the repetition here.
I at least moved it to inside the function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this to be resolved/decided in this PR? how much space savings are we talking here? I'd vote to leave it as is without TODOs unless we run into a problem with the canonical structure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I'd definitely say do a size check for typical and maybe some pathological pages before landing in
default-config
, but better to default to the straightforward encoding if it's reasonable in size.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is after removing fullpage screenshots from experimental; and removed resource summary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
100K doesn't seem like a showstopper, even if it is suprisingly large just for some file names.
Maybe leave an issue rather than TODO to explore flattening save difference if we ever need some LHR trimming?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when does this happen? If it happens for decent-sized scripts, should they be included in some way still? (even if just an "other" category or whatever). If it's just for type checking or shouldn't really occur, add a comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was accidentally skipping all scripts without a source map. Messed that up during some refactoring.