Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clients(psi): show disclaimer and calclink #10936

Merged
merged 1 commit into from
Jun 16, 2020
Merged

clients(psi): show disclaimer and calclink #10936

merged 1 commit into from
Jun 16, 2020

Conversation

paulirish
Copy link
Member

In #6110 we removed this as there was already existing "may vary" text.

But then in cl/246846050 (may 2019) we updated the UI and got rid of PSI's text

So we should have restored this then, but didn't notice.

@paulirish paulirish requested a review from a team as a code owner June 10, 2020 00:32
@paulirish paulirish requested review from brendankenny and removed request for a team June 10, 2020 00:32
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for some reason I thought maybe we sent this text in the psi.js return value as well but I guess it's just the score gauge and scale.

LGTM

@paulirish paulirish merged commit f90c39c into master Jun 16, 2020
@paulirish paulirish deleted the psidisclaimer branch June 16, 2020 22:53
gMakunde pushed a commit to gMakunde/lighthouse that referenced this pull request Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants