Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc(changelog): add missing 6.0.0 new contributors #10821

Merged
merged 1 commit into from
May 20, 2020

Conversation

brendankenny
Copy link
Member

Fixes oversight in #10807 where two new contributors (both with significant contributions) weren't included in the changelog. See conversation starting in #10807 (comment).

Sorry @jayaddison and @chruxin!

@brendankenny brendankenny requested a review from a team as a code owner May 20, 2020 16:11
@brendankenny brendankenny requested review from Beytoven and removed request for a team May 20, 2020 16:11
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

We should try to find a way to automate that github username conversion at some point so humans don't have to, I imagine that's rough :)

@brendankenny
Copy link
Member Author

haha, it wasn't pretty for 29 (and it should have been worse with 31 :)

@devtools-bot devtools-bot merged commit e63cde9 into master May 20, 2020
@devtools-bot devtools-bot deleted the newcontribsfix branch May 20, 2020 16:33
@jayaddison
Copy link
Contributor

Awesome, and no probs at all - thanks @brendankenny :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants