v6.0.0 #10780
Merged
v6.0.0 #10780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GoogleChrome/lighthouse-hackers i'd like to land this before anything else gets merged to master. |
patrickhulce
approved these changes
May 14, 2020
Comment on lines
+17
to
+18
| ~~ TODO: https://chromiumdash.appspot.com/schedule ~~ | ||
| We expect this release to ship in the DevTools of Chrome XX. |
There was a problem hiding this comment.
Suggested change
| ~~ TODO: https://chromiumdash.appspot.com/schedule ~~ | |
| We expect this release to ship in the DevTools of Chrome XX. | |
| We expect this release to ship in the DevTools of Chrome 84. |
yes?
|
Can you just roll from master w/ the "6.0" version numbers staged, and we can skip committing a not-done version bump/changelog? the commit hash in chromium would then be latest master, and be a slight lie, but nbd imo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To all interested parties:
We're cutting the release today on Github.
However we will be releasing it to NPM, etc early next week.
We'll have a polished changelog and blog post, then.