core(emulation): keep DPR at 2.625 for mobile emulation #10749
Conversation
There was a problem hiding this comment.
I love this and think it's a low risk way to stay on par with perf advice in <=5.x.x.
It's also incredibly unlikely IMO, that someone is going to lookup the Moto G4, learn it's a DPR of 3 and then hard code the images for a DPR of 3 instead of using window.devicePixelRatio and then complain about it...
We can consider eventually doing DPR 1 or 1.5 or something in a future breaking version if we'd like to get more aggressive.
Does anyone object to landing this for 6.0 to maintain parity?
|
FYI 4 years ago it was set to 2.625 https://github.com/GoogleChrome/lighthouse/blame/e0b44a57c935b1abb53babcd04916c53d5158d39/lighthouse-core/lib/emulation.js#L23 currently, in LH's unpublished state it is 3. this PR sets it to 2, slightly more aggressive than the last version. |
lighthouse-core/lib/emulation.js
Outdated
| // Moto G4 is really 3, but a higher value here works against | ||
| // our perf recommendations. | ||
| // https://github.com/GoogleChrome/lighthouse/issues/10741#issuecomment-626903508 | ||
| deviceScaleFactor: 2, |
|
we decided to slow down on this and simply not change this value between 5.6 and 6.0 |
connorjclark
changed the title
#10741 (comment)