Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(maskable-icon): update description link to new web.dev guide #10714

Merged
merged 2 commits into from
May 6, 2020

Conversation

kaycebasques
Copy link
Contributor

Summary

Links the maskable icon report UI to the new dedicated guide on the topic.

The existing link (https://web.dev/maskable-icon) was arguably good enough but this new one keeps the documentation experience consistent with the rest of the audits, provides concise directions on how to pass the audit, and also mentions the important implementation detail that Lighthouse doesn't actually do anything with the image that's specified as maskable.

Related Issues/PRs

@kaycebasques kaycebasques requested a review from a team as a code owner May 6, 2020 21:10
@kaycebasques kaycebasques requested review from paulirish and removed request for a team May 6, 2020 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants