core(charset): add description link to web.dev guide #10689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaycebasques
commented
May 1, 2020
| @@ -24,7 +24,7 @@ const UIStrings = { | |||
| /** Description of a Lighthouse audit that tells the user why the charset needs to be defined early on. */ | |||
| description: 'A character encoding declaration is required. It can be done with a <meta> tag ' + | |||
| 'in the first 1024 bytes of the HTML or in the Content-Type HTTP response header. ' + | |||
| '[Learn more](https://www.w3.org/International/questions/qa-html-encoding-declarations).', | |||
| '[Learn more](https://web.dev/charset).', | |||
There was a problem hiding this comment.
brendankenny
changed the title
brendankenny
changed the title
patrickhulce
approved these changes
May 1, 2020
There was a problem hiding this comment.
LGTM, feel free to land once it goes live @kaycebasques
As for the docs themselves..
Might be nice to mention some of the performance consequences that prioritized the original issue too. That comment also calls out when it's an actual problem (it's based on the domain name) would be cool to have the docs say specifically when it happens too, but not a big deal. It looks good as-is too.
|
Updated the guide to mention the performance consideration and merged the documentation PR (page should be live in 10 minutes) |
|
@patrickhulce I don't authorization to merge
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Links the
charsetaudit description to the new web.dev guide dedicated to that topic.Related Issues/PRs
GoogleChrome/web.dev#2771