-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests(ci): authenticate protoc download #10661
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
.github/workflows/ci.yml
Outdated
@@ -27,6 +27,7 @@ jobs: | |||
uses: arduino/setup-protoc@master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we lock to this version of the action so we dont leak the token to whatever lands in their master tomorrow?
i think arduino/[email protected]
will work? if not we'll need to ask them to rls
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jk we can do a specific commit: arduino/setup-protoc@7ad700d
thx https://help.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idstepsuses
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh that's so cool! it never occurred to me that github actions can keep secrets from being in the environment already unlike travis. that's dope :)
Here's where the token ends up being used: https://github.com/arduino/setup-protoc/blob/7ad700d3b20e2a32b35d2c17fbdc463891608381/lib/installer.js#L125-L136 |
Co-Authored-By: Paul Irish <[email protected]>
running into github api rate limiting errors when downloading protoc, which is weird because it's github making the request. Turns out we need to supply a token :)
arduino/setup-protoc#6
Also drops CI runs on
push