Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(ci): authenticate protoc download #10661

Merged
merged 2 commits into from
Apr 29, 2020
Merged

tests(ci): authenticate protoc download #10661

merged 2 commits into from
Apr 29, 2020

Conversation

brendankenny
Copy link
Member

running into github api rate limiting errors when downloading protoc, which is weird because it's github making the request. Turns out we need to supply a token :)

arduino/setup-protoc#6

Also drops CI runs on push

@brendankenny brendankenny requested a review from a team as a code owner April 28, 2020 21:52
@brendankenny brendankenny requested review from patrickhulce and removed request for a team April 28, 2020 21:52
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -27,6 +27,7 @@ jobs:
uses: arduino/setup-protoc@master
Copy link
Member

@paulirish paulirish Apr 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we lock to this version of the action so we dont leak the token to whatever lands in their master tomorrow?

i think arduino/[email protected] will work? if not we'll need to ask them to rls

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jk we can do a specific commit: arduino/setup-protoc@7ad700d

thx https://help.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idstepsuses

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh that's so cool! it never occurred to me that github actions can keep secrets from being in the environment already unlike travis. that's dope :)

@paulirish
Copy link
Member

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@vercel vercel bot requested a deployment to Preview April 28, 2020 23:08 Abandoned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants