i18n(import): new audits, dropdowns, and columns #10645

exterkamp · 2020-04-27T21:07:11Z

Summary
Automated import of strings.

Related Issues/PRs
fixes: #10581

patrickhulce

I think tests are complaining about the same comment I had.

Not sure what other role I have in approving this :)

patrickhulce · 2020-04-28T02:09:19Z

lighthouse-core/lib/i18n/locales/cs.json

+  "lighthouse-core/audits/metrics/cumulative-layout-shift.js | description": {
+    "message": "Kumulativní změna rozvržení je součet všech změn rozvržení, k nimž došlo při načítání stránky. Změna rozvržení je libovolná změna pozice, k níž u prvku dojde poté, co je viditelný uživateli. Všechny změny rozvržení se zaznamenávají a přiděluje se jim skóre. Výsledné kumulativní skóre má hodnotu mezi 0 a 1. 0 znamená perfektně stabilní stránku, skóre >= 0,5 znamená vysoce proměnlivou stránku. [Další informace](https://web.dev/cls)"
+  },
+  "lighthouse-core/audits/metrics/cumulative-layout-shift.js | title": {


isn't this out-of-date already? 😬 do we need another import to get the correct one for the move to i18n.js cumulativeLayoutShiftMetric?

@exterkamp can we immediately do another import just to get the default locale here fixed?

poor translators, I bet the description was a lot of work

@exterkamp can we immediately do another import just to get the default locale here fixed?

Yes. But an automated import will reset all languages to English for that string. So. We can manually commit the new, correct English one and export everything at the same time. This will reset the default, and start translating the new one, without poisoning the translated ones.

Are these ones just so bad that we shouldn't commit them, or that they just aren't perfect and need to be redone immediately (but we could still land this)?

I think there are two separate issues going on here @exterkamp.

The titles of CLS and LCP were moved out of the metric files into i18n.js. The string didn't change so translations should be fine, but the key did and AFAICT in all languages we'll be using the english name for CLS and LCP right now which would be pretty bad for 6.0 IMO.

The description of CLS changed to be shorter. I see no need to force a retranslation of all of these before 6.0 if we can still get the longer translated version in. It seems fine if it lags a little bit.

I am mostly concerned about the first bullet.

The titles of CLS and LCP were moved out of the metric files into i18n.js. The string didn't change so translations should be fine, but the key did and AFAICT in all languages we'll be using the english name for CLS and LCP right now which would be pretty bad for 6.0 IMO.

Since the string didn't change, just the key, and we don't send the key to the translators, will these insta-translate if we resubmit, @exterkamp?

⬆️ THIS! :)

Thanks @brendankenny for saying what I was horribly trying to get at with "do we need another import to get the correct one" 😆

i think we ask @exterkamp this once a quarter. can we write the answer in the docs

brendankenny · 2020-04-28T17:57:00Z

So I think the plan now is to

land report: add Trust & Safety group under Best Practices #10623 (to get new Best Practices group strings)
re-import strings to TC
get a same-day string dump that will have CLS and LCP titles in their new location
update this PR with those strings (and merge)
do another string PR when the new strings (CLS description, Best Practices group titles) are ready

?

paulirish · 2020-05-06T00:57:01Z

So I think the plan now is to

land report: add Trust & Safety group under Best Practices #10623 (to get new Best Practices group strings)

re-import strings to TC

get a same-day string dump that will have CLS and LCP titles in their new location

update this PR with those strings

^ done done done done

(and merge)

do another string PR when the new strings (CLS description, Best Practices group titles) are ready

^ not done.

brendankenny

LGTM, though strings are expensive in the lr bundle, huh

brendankenny · 2020-05-06T15:25:47Z

lighthouse-core/lib/i18n/locales/de.json

@@ -630,7 +648,7 @@
    "message": "Für Nutzer mit langsamen Verbindungen können externe Skripts, die dynamisch über `document.write()` eingefügt werden, den Seitenaufbau um einige Sekunden verzögern. [Weitere Informationen.](https://web.dev/no-document-write)"
  },
  "lighthouse-core/audits/dobetterweb/no-document-write.js | failureTitle": {
-    "message": "Verwendet `document.write()`"
+    "message": "Avoid `document.write()`"


one weird thing is that all the languages adopted the english string for the document.write failureTitle, which doesn't seem like the correct behavior? I would assume it would have been dropped since there wasn't a new translation

@exterkamp

Yeah I did see these removals:

but the lack of removal for these others is a lil weird.

Shane clarified that we only 'remove messages' when its not part of our source files. (not in the ctc)

We don't remove messages that are not-yet-translated. And they are deliberately populated with the fallback (en) strings.

paulirish · 2020-05-08T20:43:06Z

Latest export all the recent translations of our document.write wording tweak. We're at 100% now.

I'll merge now.

patrickhulce · 2020-05-11T15:04:38Z

Bot isn't working, so merging for Paul.

exterkamp added 2 commits April 20, 2020 14:26

import strings

62dd6e1

new import for 4-27

14be20f

exterkamp requested a review from a team as a code owner April 27, 2020 21:07

exterkamp requested review from patrickhulce and removed request for a team April 27, 2020 21:07

googlebot added the cla: yes label Apr 27, 2020

Merge branch 'master' into import-lr-translations-04-20

0ef808e

vercel bot deployed to Preview April 27, 2020 21:11 View deployment

devtools-bot assigned patrickhulce Apr 27, 2020

devtools-bot added the waiting4reviewer label Apr 27, 2020

patrickhulce reviewed Apr 28, 2020

View reviewed changes

patrickhulce added waiting4committer and removed waiting4reviewer labels Apr 28, 2020

roll tc strings after round trip

79157a2

vercel bot deployed to Preview May 6, 2020 00:56 View deployment

brendankenny approved these changes May 6, 2020

View reviewed changes

brendankenny reviewed May 6, 2020

View reviewed changes

post-dump export

35abf4b

vercel bot deployed to Preview May 8, 2020 20:40 View deployment

bundlesize

bc15c42

vercel bot deployed to Preview May 8, 2020 20:45 View deployment

paulirish added the land-when-ci-is-green label May 8, 2020

Merge branch 'master' into import-lr-translations-04-20

73dc1c9

vercel bot deployed to Preview May 8, 2020 22:53 View deployment

patrickhulce merged commit d95c31b into master May 11, 2020

patrickhulce deleted the import-lr-translations-04-20 branch May 11, 2020 15:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

i18n(import): new audits, dropdowns, and columns #10645

i18n(import): new audits, dropdowns, and columns #10645

exterkamp commented Apr 27, 2020

patrickhulce left a comment

patrickhulce Apr 28, 2020

connorjclark Apr 28, 2020

connorjclark Apr 28, 2020

connorjclark Apr 28, 2020

exterkamp Apr 28, 2020

patrickhulce Apr 28, 2020

brendankenny Apr 28, 2020

patrickhulce Apr 28, 2020

connorjclark May 7, 2020

brendankenny commented Apr 28, 2020

paulirish commented May 6, 2020

brendankenny left a comment

brendankenny May 6, 2020

paulirish May 7, 2020 •

edited

Loading

paulirish May 8, 2020

paulirish commented May 8, 2020 •

edited

Loading

patrickhulce commented May 11, 2020

i18n(import): new audits, dropdowns, and columns #10645

i18n(import): new audits, dropdowns, and columns #10645

Conversation

exterkamp commented Apr 27, 2020

patrickhulce left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

brendankenny commented Apr 28, 2020

paulirish commented May 6, 2020

brendankenny left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

paulirish May 7, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

paulirish commented May 8, 2020 • edited Loading

patrickhulce commented May 11, 2020

paulirish May 7, 2020 •

edited

Loading

paulirish commented May 8, 2020 •

edited

Loading