Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report: improve color contrast of top-level errors #10636

Merged
merged 6 commits into from
May 12, 2020
Merged

report: improve color contrast of top-level errors #10636

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7177fd0
Changed runtime error message color themes
baseeee Mar 22, 2020
15827c0
Reduced padding on runtime error message and rounded the message box …
baseeee Apr 25, 2020
33bb1aa
Fix contrast issue and correct file inconsistencies
baseeee May 9, 2020
8f402b9
Merge branch 'master' into master
baseeee May 9, 2020
b7a38cb
Replace tabs with spaces and sort color variables
baseeee May 10, 2020
9d33ee2
Update lighthouse-core/report/html/report-styles.css
connorjclark May 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions lighthouse-core/report/html/report-styles.css
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lighthouse-core/report/html/templates.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
<!-- Lighthouse run warnings -->
<template id="tmpl-lh-warnings--toplevel">
<div class="lh-warnings lh-warnings--toplevel">
<strong class="lh-warnings__msg"></strong>
<p class="lh-warnings__msg"></p>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hwikyounglee just wanna double check we want to make this be not bold.

this:
image
image

or that:
image
image

Copy link

@hwikyounglee hwikyounglee May 10, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per the design

  • No bold
  • On the light mode: the title 'There were...' should be in orange #d04900

Could we try the color for the light mode?
I think the colors would do it without bold weight.

Side note: the orange in dark mode is #ffa400

https://yuinchien.com/sandbox/lighthouse/ (click on the (i) at the top right, and also 'd' for light/dark toggle)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the color contrast for those light colors #d04900 (text) and rgb(255, 246, 234) (background) has too low contrast according to axe :(

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if we're in a place to add or replace the color with #BD4200

It's 4.97
https://contrast-ratio.com/#%23BD4200-on-%20rgb%28255%2C%20246%2C%20234%29

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

seems good to me.

<ul></ul>
</div>
</template>
Expand Down