misc(build): disable fail-fast on gh basics workflow #10551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like the idea of running the rest so you can fix all the failures, but I don't feel strongly |
I think it generally depends on the test, but at least for the current basics tests it would be probably be more useful to continue even with failures. That may change if it's as hard to get a machine to run our actions on as it is with travis, and/or if basics gets heavier and heavier (e.g. #10549 and #10550 :) |
connorjclark
approved these changes
Apr 6, 2020
paulirish
changed the title
paulirish
added a commit
that referenced
this pull request
Apr 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If lint fails, do we want the workflow to continue and run unit tests?
Or should it just immediately give the red X feedback?
I'm fine with both, just wanted to ask folks what they think.