Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(readme): add AwesomeTechStack to lighthouse integrations #10475

Merged
merged 2 commits into from
Mar 24, 2020
Merged

docs(readme): add AwesomeTechStack to lighthouse integrations #10475

merged 2 commits into from
Mar 24, 2020

Conversation

AndreasKubasa
Copy link
Contributor

Summary

AwesomeTechStack is for all developers and designers who want to improve their website or strive to get the best out of their new project.
With technology insights you will always know what is trending now and what would be the best tech stack to use at the moment

https://awesometechstack.com/tools/analyze/documentation/

Added AwesomeTechStack to the lighthouse integrations secction
@AndreasKubasa AndreasKubasa requested a review from a team as a code owner March 17, 2020 18:28
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@AndreasKubasa
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@AndreasKubasa AndreasKubasa changed the title Added AwesomeTechStack to lighthouse integrations docs(readme): Add AwesomeTechStack to lighthouse integrations Mar 18, 2020
@AndreasKubasa AndreasKubasa changed the title docs(readme): Add AwesomeTechStack to lighthouse integrations docs(readme): add AwesomeTechStack to lighthouse integrations Mar 18, 2020
@AndreasKubasa
Copy link
Contributor Author

@benschwarz, is there something special we need to do to be mentioned @ the npms package Lighthouse Integrations part?

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat tool @AndreasKubasa thanks very much for sharing!!

not sure if you're the maintainer of this or I should use the feedback form but three quick notes on things I found if you're interested

It'd be awesome to be able to actually open up the Lighthouse report that underlies the quality score. As someone very familiar with Lighthouse I'm not sure what the quality score is presently. It says it's based on all the categories but "How it works" doesn't explain how the score is computed. Is it the average of all default LH categories?

image

the score legend is missing 40-49 ;)

image

this section seems to be about outdated libraries moreso than specific performance improvements, maybe a rename? :)

readme.md Outdated Show resolved Hide resolved
Co-Authored-By: Patrick Hulce <[email protected]>
@AndreasKubasa
Copy link
Contributor Author

@patrickhulce We updated our websites.
Thank you once again for your suggestions.

We implemented the lighthouse report view -> https://awesometechstack.com/tools/analyze/website/reports/lighthouse/?url=awesometechstack.com

when clicking on:
view-lighthouse

After implementing our user login we will add further reports and full reports for logged in users 👍

Any further suggestions from you are very welcome :)

@patrickhulce
Copy link
Collaborator

Amazing response time thanks for being so receptive @AndreasKubasa !

Found just 1 typo this time :)

These values combined are used to calculate the abverage quality score of your website.

s/abverage/average/

re:

Performance and SEO are characteristics for a good tech stack too, but the main fact that performance is related to the network makes it not suitable for our Algorythm.

We would definitely want to encourage you to consider factoring in the performance results in some way to your scoring. While the network definitely has a strong influence on the scale of performance numbers, the tech stack and decisions made in the architecture of the frontend can result in a 1s FCP or a 20s FCP, two radically different experiences (and 20s FCP would be really hard pressed to call an "awesome" tech stack 😉). As it stands currently, I think we can either remove all the references to performance in the description of this integration and proceed, or wait to factor in performance to the "quality" result and the Lighthouse report.

@AndreasKubasa
Copy link
Contributor Author

@patrickhulce

the tech stack and decisions made in the architecture of the frontend can result in a 1s FCP or a 20s FCP, two radically different experiences (and 20s FCP would be really hard pressed to call an "awesome" tech stack 😉).

💯 You are absolutely right. We have a ticket in our Roadmap which defines the weight per score, tech, quality and lighthouse quality score weights.

We will implement performance and SEO lighthouse scores into our algorithm, as we are going to release update notes to our algorithm changes, our score is adaptable to it. Technologies and best practices are changing fast so we are also focusing on a reliable score but flexible in changes.

Thank you for your input. I appreciate it!

I will come back to you when finished and released. 👍

@AndreasKubasa
Copy link
Contributor Author

@patrickhulce Thank you for encouraging us to take the performance score into account.
We implemented and published the version using all lighthouse scores 👍

Thank you for your patience.

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great job and thanks for being open to feedback! :D 💯

@patrickhulce patrickhulce merged commit 1457b4c into GoogleChrome:master Mar 24, 2020
@AndreasKubasa
Copy link
Contributor Author

@patrickhulce

Thank you for your assitance and merge ;)

Just a quick followup question. Is there a chance to get mentioned in the npm's lighthouse integrations part -> https://www.npmjs.com/package/lighthouse#lighthouse-integrations

@patrickhulce
Copy link
Collaborator

Just a quick followup question. Is there a chance to get mentioned in the npm's lighthouse integrations part -> https://www.npmjs.com/package/lighthouse#lighthouse-integrations

That happens automatically when master is published to npm. It will go out when 6.0 becomes final (it's currently in beta).

@AndreasKubasa
Copy link
Contributor Author

Sounds cool. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants