misc: add non-null annotations to keep internal lint happy #10454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
danke schön! |
|
Whose linter are we trying to keep happy? EDIT: the branch name gave me a hint :) |
|
cl/300054528
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
these were flagged by some nullability closure linter and there was a request to change them to keep it happy. Since we run with
strict/strictNullChecksthis is a no-op in tsc land, asnullisn't assignable to these types by default. Note that this check is just running on report files.Not sure why it's just these return types and not other places in these same files...I assume some of their analysis is hampered by us using tsc-isms.
cc @paulirish @exterkamp