report: update table and inline code formatting #10437
Conversation
|
Here are screenshots of Dark mode:
|
Beytoven
changed the title
| @@ -128,7 +128,7 @@ | |||
| --scorescale-width: 18px; | |||
| --section-padding-vertical: 12px; | |||
| --snippet-background-color: var(--color-gray-50); | |||
| --snippet-color: var(--color-gray-800); | |||
| --snippet-color: #0938C2; | |||
There was a problem hiding this comment.
should this be pulled out into a new color variable or does it not matter?
There was a problem hiding this comment.
Not sure. The color isn't one of the Material Design colors so I didn't think it needed it's own variable.
| @@ -1339,6 +1345,10 @@ | |||
| padding-right: 0; | |||
| } | |||
|
|
|||
| .lh-table tr { | |||
| vertical-align: baseline; | |||
There was a problem hiding this comment.
it seems like this could get us in trouble applying to all table trs--maybe there's a specific case we've been depending on the current behavior?--but I couldn't find any bad tables in the sample_v2 report so SGTM :)
There was a problem hiding this comment.
I did the same and couldn't find a place where a table is affected negatively. If it becomes an issues, I can always come back and make the formatting more specific.
Fixes #9724
Updated images below. See linked issue for before images.