-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc(viewer): mention other lighthouse channels #10384
Conversation
interessting.. on the preview-instance the viewer uses a different lighthouse logo: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks very much @staabm, exactly what we want!
the only issue I see is that the file open prompt still pops up when you click on the links because they are located within that hitbox, might need to skip our click handler if the target's localName was input
OR a
lighthouse/lighthouse-viewer/app/src/lighthouse-report-viewer.js
Lines 84 to 90 in f150573
placeholderTarget.addEventListener('click', e => { | |
const target = /** @type {?Element} */ (e.target); | |
if (target && target.localName !== 'input') { | |
fileInput.click(); | |
} | |
}); |
lol, good catch. I should have clicked one of the links ;-). fixed now, thx for the great review and feedback! |
(not sure what I need to put in the title to make the linter happy...) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @staabm !
after the change the site looks like:
closes #10335