Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc(viewer): mention other lighthouse channels #10384

Merged
merged 4 commits into from
Mar 2, 2020

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Feb 26, 2020

after the change the site looks like:

image

closes #10335

@staabm
Copy link
Contributor Author

staabm commented Feb 26, 2020

interessting.. on the preview-instance the viewer uses a different lighthouse logo:

https://lighthouse-65kq3mhz8.now.sh/viewer/

image

@patrickhulce patrickhulce self-assigned this Feb 27, 2020
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks very much @staabm, exactly what we want!

the only issue I see is that the file open prompt still pops up when you click on the links because they are located within that hitbox, might need to skip our click handler if the target's localName was input OR a

placeholderTarget.addEventListener('click', e => {
const target = /** @type {?Element} */ (e.target);
if (target && target.localName !== 'input') {
fileInput.click();
}
});

lighthouse-viewer/app/index.html Outdated Show resolved Hide resolved
@staabm
Copy link
Contributor Author

staabm commented Feb 27, 2020

the only issue I see is that the file open prompt still pops up when you click on the links because they are located within that hitbox

lol, good catch. I should have clicked one of the links ;-).

fixed now, thx for the great review and feedback!

@staabm
Copy link
Contributor Author

staabm commented Feb 27, 2020

(not sure what I need to put in the title to make the linter happy...)

@patrickhulce patrickhulce changed the title mention other lighthouse related tools/browser-extensions viewer: mention other lighthouse channels Feb 27, 2020
@patrickhulce patrickhulce changed the title viewer: mention other lighthouse channels misc(viewer): mention other lighthouse channels Feb 27, 2020
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @staabm !

@patrickhulce patrickhulce merged commit 44c305f into GoogleChrome:master Mar 2, 2020
@staabm staabm deleted the patch-1 branch March 2, 2020 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update viewer to mention web.dev/measure or PSI
3 participants