-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
report: fix link contrast issue in dark mode #10364
Conversation
I went with `--color-informative` which was already in use for some other links and it looks (locally) ok to me in order to fix #10363.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Oh wow you already fixed it! I'll update my comment then :D great work thanks! |
Co-Authored-By: Connor Clark <[email protected]>
@connorjclark thanks again for the review (1 line, 25 chars approx. and I manage to slip two typos in... :s) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! thanks for sticking to it
I went with
--color-informative
which was already in use for some other links and it looks (locally) ok to me in order to fix #10363.Summary
This PR styles
.lh-table-column--link a
elements with the custom color--color-informative
instead of the default (user agent stylesheet) color for links (see #10363 for rationale: contrast too low / a11y)This is intended as a bugfix for #10363.
The need for this change is a better visual contrast in dark mode and respecting WCAG2.1 rules along the way.
https://www.w3.org/TR/WCAG21/#contrast-minimum
Related Issues/PRs
See #10363 for original issue.