Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

viewer(css): cursor:wait indicator no longer blocked by pointer-events: none #10348

Merged
merged 1 commit into from
Feb 21, 2020

Conversation

awdltd
Copy link
Contributor

@awdltd awdltd commented Feb 17, 2020

Moved pointer-events:none from the parent wrapper for the loading screen; added it to the child instead, so that the parent retains cursor interactivity and the cursor:wait is correctly shown - fixes #10010

@awdltd awdltd requested a review from a team as a code owner February 17, 2020 09:45
@awdltd awdltd requested review from exterkamp and removed request for a team February 17, 2020 09:45
@awdltd awdltd changed the title viewer(css): moved pointer-events:none to child element to retain parent element cursor:wait viewer(css): cursor:wait indicator no longer blocked by pointer-events: none Feb 17, 2020
Copy link
Member

@exterkamp exterkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for following up on this and getting into the small details 🔍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blurred Lighthouse Report Viewer box when launching Chrome extension
4 participants