Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(readme): add a table of contents #10283

Merged
merged 1 commit into from
Jan 30, 2020
Merged

docs(readme): add a table of contents #10283

merged 1 commit into from
Jan 30, 2020

Conversation

paulirish
Copy link
Member

readme is a little long so i think a TOC would help.

I started with command npx markdown-toc readme.md but then hand-edited it a lil bit.

but mostly this PR is just a test of the review assignment. 🤞 🤞 🤞

@paulirish paulirish requested a review from a team as a code owner January 30, 2020 20:10
@paulirish paulirish requested review from patrickhulce and removed request for a team January 30, 2020 20:10
@paulirish
Copy link
Member Author

paulirish commented Jan 30, 2020 •
edited
Loading

but mostly this PR is just a test of the review assignment. 🤞 🤞 🤞

image

🎉

edit, though I can't understand why patrick would be selected if things are set to "load balance"...

image

🤣

patrickhulce
patrickhulce approved these changes Jan 30, 2020
View reviewed changes
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM though why don't we use this neat project?

https://github.com/connorjclark/toccer

😃

@connorjclark
Copy link
Collaborator

curious how you found that @patrickhulce :)

@patrickhulce
Copy link
Collaborator

curious how you found that @patrickhulce :)

Haha @paulirish told me about it and decided to have some fun with it :)

@patrickhulce patrickhulce merged commit edc1535 into master Jan 30, 2020
@patrickhulce patrickhulce deleted the paulirish-patch-1 branch January 30, 2020 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhulce patrickhulce patrickhulce approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paulirish @connorjclark @patrickhulce @googlebot