Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc(git3po): add-needs-priority, remove-needs-priority #10257

Merged
merged 1 commit into from
Feb 4, 2020
Merged

Conversation

connorjclark
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

personally I don't think this is necessary, needs-priority duplication or lacking never really affects us with the crafted queries at triage time

but I don't suppose it hurts anything

@patrickhulce
Copy link
Collaborator

revisiting the "doesn't hurt anything": it's yet another thing to run, so I'll defer to @paulirish on whether it's worth it 😆

@connorjclark
Copy link
Collaborator Author

connorjclark commented Jan 27, 2020

"worth it"? It costs zero things to run it :)

this is just a cleanliness thing. I suppose it's also a bit faster to just assign a priority label and move on, and rely on the bot to unapply needs-priority

Copy link
Member

@paulirish paulirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wfm

@paulirish paulirish merged commit 7ffb922 into master Feb 4, 2020
@paulirish paulirish deleted the git3po-2 branch February 4, 2020 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants