Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc(git3po): land-when-green #10256

Merged
merged 1 commit into from
Jan 24, 2020
Merged

misc(git3po): land-when-green #10256

merged 1 commit into from
Jan 24, 2020

Conversation

connorjclark
Copy link
Collaborator

No description provided.

patrickhulce
patrickhulce approved these changes Jan 24, 2020
View reviewed changes
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paulirish
Copy link
Member

this is gonna work? neat.

@connorjclark
Copy link
Collaborator Author

yeah I added the necessary functionality to git3po and tested it on a test repo.

@paulirish paulirish merged commit b692e11 into master Jan 24, 2020
@paulirish paulirish deleted the git3po-3 branch January 24, 2020 22:42
@paulirish
Copy link
Member

paulirish commented Jan 24, 2020 •
edited
Loading

@connorjclark i get an error: Fatal error: RangeError: Invalid time value

image

confirmed that i have the latest git3po (1.7.0) installed.

@patrickhulce
Copy link
Collaborator

patrickhulce commented Jan 24, 2020 •
edited
Loading

you're missing --start-at for that invocation @paulirish, no? we should have a better error message for it though :)

@connorjclark
Copy link
Collaborator Author

I omitted the start at because you'll be providing one in the cli.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhulce patrickhulce patrickhulce approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@connorjclark @paulirish @patrickhulce @googlebot