-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc(git3po): lock-resolved #10255
misc(git3po): lock-resolved #10255
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we about to get a flood of 10000 notifications when this merges? Or because of started at very recent we're OK?
For each new rule the idea is that Paul will run it initially with an early
start date, and then the cron will take up maintenance. For this one in
particular, yeah it'd be a big bandaid so perhaps makes sense to do it
during next bug triage, when we blow ourselves up any how
…On Thu, Jan 23, 2020, 6:18 PM Patrick Hulce ***@***.***> wrote:
***@***.**** commented on this pull request.
Are we about to get a flood of 10000 notifications when this merges? Or
because of started at very recent we're OK?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#10255?email_source=notifications&email_token=AA7CAMXPQXS2QG2YYMPVDZTQ7JFX3A5CNFSM4KK6EUVKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCS45JBA#pullrequestreview-347722884>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA7CAMUWVUDQTO3PPZWQGJTQ7JFX3ANCNFSM4KK6EUVA>
.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is true that we're literally talking about ~6,000 emails.
Could we be more surgical about this? What issues motivated this idea again?
The maintainer of a tool that does just this summarizes my thoughts: dessant/lock-threads#13 (comment) Prompted by a recent surge in necrobumping. I wasn't keeping count, but granted it wasn't an overwhelming amount. Sometimes it was spam, sometimes it was a similar issue that would have been more useful as a new issue w/ the template filled out. Don't we all just mass-delete GH emails at bug triage time anyways? |
Proposal: we only do this moving forward and manually apply a label to issues that get bumped in the meantime to have the bot autolock them as well? All 6000 seems like overkill and I don't think my plebeian gmail will be able to handle it :) |
some of us do. but in addition to the 6 of us that know about triage, we have >500 people who also watch the repo and get emails.
I would prefer the manual approach as well. We apply a label and bot follows up with a lock sgtm. |
No description provided.