-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add protobuf install directions #10250
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks for hunting down!
readme.md
Outdated
sudo python setup.py install --cpp_implementation | ||
``` | ||
|
||
Also, see the [official installation instructions](https://github.com/protocolbuffers/protobuf#protocol-compiler-installation). Note that using a package manager to install will result in the latest version which **isn't** compatible with our output. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would brew install [email protected]
work though?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
homebrew supports versions like that? i swear it was very anti- installing non-latest versions.
assuming it does, i think this would work. it's interesting that the homebrew formula installs the binary and then selectively sets up the python bindings, but ignores the 7 other language bindings... :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
they definitely used to make it very difficult but they deprecated homebrew/versions
and made the process easier. there are some restrictions on the versions they will support but they roughly do support that syntax now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AHHHHHHHHHH this is great. :)
Co-Authored-By: Patrick Hulce <[email protected]>
okay i think these are reproducible and good.
i'm not sure when they changed the format that results in this empty object to null change, but it was between 3.7.1 and 3.11.2.