Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add protobuf install directions #10250

Merged
merged 5 commits into from
Jan 25, 2020
Merged

docs: add protobuf install directions #10250

merged 5 commits into from
Jan 25, 2020

Conversation

paulirish
Copy link
Member

okay i think these are reproducible and good.

i'm not sure when they changed the format that results in this empty object to null change, but it was between 3.7.1 and 3.11.2.

@paulirish paulirish changed the title docs: add proto install directions docs: add protobuf install directions Jan 22, 2020
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for hunting down!

readme.md Outdated
sudo python setup.py install --cpp_implementation
```

Also, see the [official installation instructions](https://github.com/protocolbuffers/protobuf#protocol-compiler-installation). Note that using a package manager to install will result in the latest version which **isn't** compatible with our output.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would brew install [email protected] work though?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

homebrew supports versions like that? i swear it was very anti- installing non-latest versions.

assuming it does, i think this would work. it's interesting that the homebrew formula installs the binary and then selectively sets up the python bindings, but ignores the 7 other language bindings... :)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they definitely used to make it very difficult but they deprecated homebrew/versions and made the process easier. there are some restrictions on the versions they will support but they roughly do support that syntax now

https://docs.brew.sh/Versions#acceptable-versioned-formulae

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AHHHHHHHHHH this is great. :)

readme.md Outdated Show resolved Hide resolved
Co-Authored-By: Patrick Hulce <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants