docs: Fix broken link to aria-toggle-field-name #10246
Conversation
msomji
requested review from
brendankenny,
exterkamp,
patrickhulce and
paulirish
as code owners
There was a problem hiding this comment.
Thanks for doing this!
The only hesitation I have with sending this through, is that everything in ...locales/.* should be machine edited in an i18n import (except en and en-XL). Really the only change needed is to lighthouse-core/audits/accessibility/aria-toggle-field-name.js, and then update the en and en-XL automatically with yarn i18n:collect-strings, then we will import the new links on the next auto-import. This same thing happened once with a PR not too long ago. It makes me want to lock down the .../locales/.* folder, but at the end of the day, these changes fix it faster than waiting for me to run the round trip scripts, so 🤷♂️ This is probably a fine way of updating them until the auto import comes in and no-op's it anyway.
|
@exterkamp can you file an issue to track the i18n process changes you're hinting at? once that's sorted you can add |
|
tracking in #10276 |
Addresses #10243
docs: Fix broken link to aria-toggle-field-name.