Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(smokehouse): make bytes gzip size checks less restrictive #10227

Merged
merged 4 commits into from
Jan 15, 2020

Conversation

connorjclark
Copy link
Collaborator

@connorjclark connorjclark commented Jan 15, 2020

This change makes sense in isolation, but in particular I'm doing this to avoid an unnecessary modification to this smoke test expectation for LR (transfer sizes are different b/c response headers). I changed resource size too just b/c there's no need to be so specific.

Copy link
Member

@exterkamp exterkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine 🤷‍♂️

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants