core(resource-summary): ignore /favicon.ico #10190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
requested review from
brendankenny,
exterkamp and
patrickhulce
as code owners
patrickhulce
approved these changes
Jan 8, 2020
There was a problem hiding this comment.
LGTM, @khempenius you still feel good about this direction?
| @@ -130,7 +130,7 @@ module.exports = [ | |||
| }, | |||
| { | |||
| resourceType: 'other', | |||
| countOverBudget: '1 request', | |||
There was a problem hiding this comment.
should we change other budget to 0 to preserve this result? IMO we already exercise the different possible permutations enough but we thought we needed to set an other budget initially so... :)
There was a problem hiding this comment.
i considered that, but what a strange budget ...
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #9874